Hi,
Am 11.06.24 um 23:23 schrieb Laurent Pinchart:
On Tue, Jun 11, 2024 at 09:04:28AM +0300, Dan Carpenter wrote:
On Mon, Jun 10, 2024 at 11:02:17PM +0200, Stefan Wahren wrote:
The service_callback has 5 levels of indentation, which makes it
hard to read. Reduce this by splitting the code in a new function
service_single_message() as suggested by Laurent Pinchart.
Signed-off-by: Stefan Wahren <wahrenst@xxxxxxx>
To be honest, I liked the version of this patch which Laurent didn't
like. Even after pulling this code into a separate function, I'd still
support flipping the conditions around and adding the goto...
Laurent, you really didn't like the goto?
I won't nack it, but I really think gotos seriously hinder readability,
with the exception of error paths.
so at least you both are fine with the split approach here (assuming the
Dan's comment will be fixed in V3)?
