Hi Laurent,
Am 11.06.24 um 23:22 schrieb Laurent Pinchart:
Hi Stefan,
On Wed, Jun 05, 2024 at 12:11:41PM +0200, Stefan Wahren wrote:
Am 05.06.24 um 09:11 schrieb Laurent Pinchart:
On Tue, Jun 04, 2024 at 07:28:58PM +0200, Stefan Wahren wrote:
The whole benefit of this encapsulating struct is questionable.
It just stores a flag to signalize the init state of vchiq_arm_state.
Beside the fact this flag is set too soon, the access to uninitialized
members should be avoided per design.
Do you have plans to address the design ?
by using kzalloc and assigning platform_state at the end of
vchiq_platform_init_state, i would consider this as fulfilled. Or do you
care about the possible platform_state NULL pointer?
Reading the commit message, I thought you meant further changes were
need to fix the design. A clarification in the commit message could be
useful.
i missed to mention it in the V2 changelog, but i shorten the sentence
there to avoid the confusion. Is it better in V2 or does it still need
adjustment?
