Re: [PATCH] staging: vt6656: Fix checkpatch unnecessary parentheses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Remove unnecessary parentheses - according to checkpatch.pl strict

Signed-off-by: Teddy Engel <engel.teddy@xxxxxxxxx>


Hi Teddy,

your patch creates a checkpatch warning:
WARNING: A patch subject line should describe the change not the tool that found it

The next thing that worries me is that the fix does not increase the
readability of the code for me. I think overview is better with
brackets.

I also think that you are doing two things at a time. You are changing
the TODO file and the brackets.

I would change only the TODO file.

Thanks for your support.

Bye Philipp




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux