On Mon, Mar 11, 2024 at 11:46 PM Alison Schofield <alison.schofield@xxxxxxxxx> wrote: > 'rc' is typically used for cases like this. If the name of the function > being called is reasonably intuitive, then 'rc' suffices for the return > value. Greetings Alison, Thank you for the feedback, well noted. > 'Also' signals that this patch is trying to do more than one thing. > One type of 'thing' per patch please. Dan has already address this, perhaps, I did not write the message correctly, suggesting that the patch does more than one thing. > The commit message prefixes are off. Please see First Patch Tutorial > Section: "Following the Driver commit style" > > Patch fails checkpatch. Please see First Patch Tutorial Sections: > "Git post-commit hooks" and "Understand patch best practices" I will definitely fix these, thanks again immensely. --