Re: [PATCH] staging: p80211conv: Rename local foo to decrypt_check

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

On Mon, Mar 11, 2024 at 07:07:55PM +0100, Felix N. Kimbu wrote:
> @@ -185,14 +185,14 @@ int skb_ether_to_p80211(struct wlandevice *wlandev, u32 ethconv,
>  		p80211_wep->data = kmalloc(skb->len, GFP_ATOMIC);
>  		if (!p80211_wep->data)
>  			return -ENOMEM;
> -		foo = wep_encrypt(wlandev, skb->data, p80211_wep->data,
> -				  skb->len,
> -				  wlandev->hostwep & HOSTWEP_DEFAULTKEY_MASK,
> -				  p80211_wep->iv, p80211_wep->icv);
> -		if (foo) {
> +		decrypt_check = wep_encrypt(wlandev, skb->data, p80211_wep->data,
> +				  					skb->len,
> +									wlandev->hostwep & HOSTWEP_DEFAULTKEY_MASK,
> +									p80211_wep->iv, p80211_wep->icv);

With the rename the indenting did need to be updated, yes.  However it
should have been:

		decrypt_check = wep_encrypt(wlandev, skb->data, p80211_wep->data,
				  	    skb->len,
					    wlandev->hostwep & HOSTWEP_DEFAULTKEY_MASK,
					    p80211_wep->iv, p80211_wep->icv);

[tab][tab][tab][tab][tab][space][space][space][space]skb->len,

See my blog for how to resend a patch:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter