On Mon, Mar 11, 2024 at 03:46:29PM -0700, Alison Schofield wrote: > On Mon, Mar 11, 2024 at 07:07:55PM +0100, Felix N. Kimbu wrote: > > This change renames the local variable foo to decrypt_check in functions > > skb_ether_to_p80211(...) and skb_p80211_to_ether(...), giving intuitive > > meaning to the identifier. > > 'rc' is typically used for cases like this. If the name of the function > being called is reasonably intuitive, then 'rc' suffices for the return > value. > > > > > It also indents the parameters to match the the opening parentheses. > > 'Also' signals that this patch is trying to do more than one thing. > One type of 'thing' per patch please. > The name change did force a re-indent. The v2 re-indent was wrong too though. regards, dan carpenter
