> Instead of this patch, can you please audit the callers of this function? How will the determination evolve further if null pointer checks would be still relevant for three input parameters according to this function implementation at the moment? https://elixir.bootlin.com/linux/v6.3-rc7/source/drivers/staging/media/atomisp/pci/atomisp_cmd.c#L2721 > I expect that you will likely find that the callers > already unconditionally deref css_param themselves, > or they guarantee a non NULL value in other ways > (e.g. address of local variable). > > So I expect that the check can simply be dropped completely, > which would be a much better fix. Will affected implementation details be reconsidered any more? Regards, Markus
