> Instead of this patch, can you please audit the callers of this function? Did any analysis tool publish a call tree already (according to your enquiry)? https://elixir.bootlin.com/linux/v6.3-rc6/source/drivers/staging/media/atomisp/pci/atomisp_cmd.c#L2721 > I expect that you will likely find that the callers > already unconditionally deref css_param themselves, or they > guarantee a non NULL value in other ways (e.g. address of > local variable). > > So I expect that the check can simply be dropped completely, > which would be a much better fix. Are you really looking for ways to omit null pointer checks for three input parameters here? Would you like to increase the application of any annotations or API attributes? Regards, Markus
