Re: [PATCH] staging: vchiq_arm: Make vchiq_platform_init() static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,

Am 18.04.23 um 13:23 schrieb Simon Horman:
vchiq_platform_init() is only used in this file so it can be static.

clang-16 with W=1 reports:

  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for function 'vchiq_platform_init' [-Werror,-Wmissing-prototypes]
  int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
      ^
  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:1: note: declare 'static' if the function is not intended to be used outside of this translation unit

Signed-off-by: Simon Horman <horms@xxxxxxxxxx>

this is not the first attempt to fix this [1]. But maybe this has been fixed in the meantime.

[1] - https://lore.kernel.org/linux-staging/20221022043548.1671644-1-scottjcrouch@xxxxxxxxx/#t




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux