Re: [PATCH] staging: vme_user: Replace "<<" with BIT macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Abhirup Deb <abhirupdeb@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] staging: vme_user: Replace "<<" with BIT macro
From: Dan Carpenter <error27@xxxxxxxxx>
Date: Sat, 18 Mar 2023 10:51:00 +0300
Cc: Martyn Welch <martyn@xxxxxxxxxxxx>, Manohar Vanga <manohar.vanga@xxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx
In-reply-to: <ZBVhmU+5dVoExIH9@li-27defe4c-32e1-11b2-a85c-e202e9981075.ibm.com>
References: <ZBVhmU+5dVoExIH9@li-27defe4c-32e1-11b2-a85c-e202e9981075.ibm.com>

On Sat, Mar 18, 2023 at 12:30:41PM +0530, Abhirup Deb wrote:
> -#define TSI148_PCFS_STAT_SELTIM        (3<<9)	/* DELSEL Timing */
> +#define TSI148_PCFS_STAT_SELTIM        BIT(9)	/* DELSEL Timing */

This patch is buggy.

regards,
dan carpenter

Follow-Ups:
- Re: [PATCH] staging: vme_user: Replace "<<" with BIT macro
  - From: Abhirup Deb

References:
- [PATCH] staging: vme_user: Replace "<<" with BIT macro
  - From: Abhirup Deb

Prev by Date: [PATCH] staging: vme_user: Replace "<<" with BIT macro
Next by Date: Re: [PATCH v2] staging: sm750: Rename function to avoid CamelCase
Previous by thread: [PATCH] staging: vme_user: Replace "<<" with BIT macro
Next by thread: Re: [PATCH] staging: vme_user: Replace "<<" with BIT macro
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]

Powered by Linux