On Sat, Mar 18, 2023 at 10:51:00AM +0300, Dan Carpenter wrote: > On Sat, Mar 18, 2023 at 12:30:41PM +0530, Abhirup Deb wrote: > > -#define TSI148_PCFS_STAT_SELTIM (3<<9) /* DELSEL Timing */ > > +#define TSI148_PCFS_STAT_SELTIM BIT(9) /* DELSEL Timing */ > > This patch is buggy. > > regards, > dan carpenter Dan, Thank you for your help! I will be amending the changes in a v2 of the patch. Regards, Abhirup Deb