On 3/18/23 12:14, Ira Weiny wrote: > Bagas Sanjaya wrote: >> On Wed, Mar 15, 2023 at 11:35:37PM +0800, Kloudifold wrote: >>> Subject: [PATCH v2] staging: sm750: Rename functions from CamelCase to snake case >> >> If I only see the subject above, which functions are renamed? I have >> to see the actual diff if the patch description doesn't answer that. >> In this case, I think the proper subject would be `[PATCH v3] staging: >> sm750: Rename sm750_hw_cursor_* functions to snake_case`. > > No. The oneliner is a brief overview. > > It is perfectly appropriate to have to look at the diff to see what was > done. The commit message is to state what the problem was and how it was > fixed. > OK but I prefer to be more explicit in the subject and the description so that I don't have to guess :) -- An old man doll... just what I always wanted! - Clara
