On ١٥/٣/٢٠٢٣ ٢٠:٤٧, Ira Weiny wrote:
Menna Mahmoud wrote:
add a space before and after the operator, for readability.
Reported By checkpatch script:
CHECK: spaces preferred around that '+' (ctx:VxV)
+ image->bus_resource.name = kmalloc(VMENAMSIZ+3, GFP_ATOMIC);
^
CHECK: spaces preferred around that '<<' (ctx:VxV)
+ temp_ctl &= ~(3<<4);
^
CHECK: spaces preferred around that '>>' (ctx:VxV)
+ cbar = (cbar & TSI148_CRCSR_CBAR_M)>>3;
^
CHECK: spaces preferred around that '<<' (ctx:VxV)
+ iowrite32be(cbar<<3, bridge->base + TSI148_CBAR);
Similar comment to what Fabio made.
But I'll add some formatting comments.
It looks like you have submitted a 2 patch series which fixes all the
checkpatch errors in the vme_user driver?
yes, each patch for specific error in multi-position.
Kudos for separating out the 2 patches for the 2 different types of
checkpatch errors! And for submitting a series which fixes the entire
driver!
to double check that i understood right, you mean I should create one
patch-set for one error?
Because I have already done that in previous patch but Julia commented
on it that no need to create patch-set
for the same error.
But you should also include a cover letter for your series.
okay, I will include it.
How are you creating this series? Are you using 'git format-patch'?
'b4'? If not using 'b4' I strongly recommend it.[*]
yes, used ' git format-patch` but I will try b4.
Both of those tools can help with formatting a cover letter and b4 will
help keep track of multiple versions of the series as you fix things.
Ira
[*] https://git.kernel.org/pub/scm/utils/b4/b4.git
Thanks,
Menna
