Menna Mahmoud wrote: > > On ١٥/٣/٢٠٢٣ ١٥:٤٥, Julia Lawall wrote: > > > > On Wed, 15 Mar 2023, Menna Mahmoud wrote: > > > >> remove unnecessary blank lines before a close brace > >> as reported by checkpatch script > >> > >> "CHECK: Blank lines aren't necessary before a close brace '}'" > >> > >> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@xxxxxxxxx> > >> ---- > > This should be three -s, not four. > > > >> changes in v2: > >> edit commit message > >> --- > > -s aren't needed here. > > > > julia > > > I see, Thanks Julia I agree with Julia that they are not needed here but they also don't hurt anything. git format-patch (or b4 etc) add another '---' to the commit message automatically. https://lore.kernel.org/all/20221216-cxl-ev-log-v7-2-2316a5c8f7d8@xxxxxxxxx/ So assuming you had something like ... <quote> ---- changes in v2: edit commit message </quote> ... in the patch commit message. That is perfectly ok and I would not worry about the tools adding a second '---'. But as Julia said you must make sure to have only 3 '-'s. :-D Ira
