Hi Jacopo,
Thank you for the patch.
On Fri, Feb 18, 2022 at 07:34:20PM +0100, Jacopo Mondi wrote:
> Add support for the BGR888_1X24 image formats.
>
> The BGR888 format definition matches how pixel components are sent on
> the wire according to the CSI-2 specification.
A bit more information that you may want to capture, for readers who are
not familiar with this:
No existing media bus codes describe exactly the way data is transferred
on the CSI-2 bus. This is not a new issue, the CSI-2 YUV422 8-bit format
is described by MEDIA_BUS_FMT_UYVY8_1X16 which is an arbitrary
convention and not an exact match. Use the MEDIA_BUS_FMT_BGR888_1X24 to
follow the same convention, based on the order in which bits are
transmitted over the CSI-2 bus.
> Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
> ---
> drivers/media/platform/imx/imx-mipi-csis.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/media/platform/imx/imx-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c
> index c7a771e3fdf3..fdf133f81c5b 100644
> --- a/drivers/media/platform/imx/imx-mipi-csis.c
> +++ b/drivers/media/platform/imx/imx-mipi-csis.c
> @@ -366,6 +366,11 @@ static const struct csis_pix_format mipi_csis_formats[] = {
> .data_type = MIPI_CSI2_DATA_TYPE_RGB565,
> .width = 16,
> },
> + {
}, {
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> + .code = MEDIA_BUS_FMT_BGR888_1X24,
> + .data_type = MIPI_CSI2_DATA_TYPE_RGB888,
> + .width = 24,
> + },
> /* RAW (Bayer and greyscale) formats. */
> {
> .code = MEDIA_BUS_FMT_SBGGR8_1X8,
--
Regards,
Laurent Pinchart
