Hi Arinc! On Mon, Jan 24, 2022 at 1:45 PM Arınç ÜNAL <arinc.unal@xxxxxxxxxx> wrote: > > Hey everyone, > > In preperation to mainline mt7621-dts; fix formatting, dtc warning on > switch0@0 node and pinctrl properties for ethernet node on the mt7621.dtsi. > Move the GB-PC2 specific external phy configuration on the main dtsi to > GB-PC2's devicetree, gbpc2.dts. > > Now that pinctrl properties are properly defined on the ethernet node, > GMAC1 will start working. > > Traffic flow on GMAC1 was tested on a mt7621a board with these modes: > External phy <-> GMAC1 > PHY 0/4 <-> GMAC1 > > Cheers. > Arınç Nitpick: next time try to put also a subject like "staging: mt7621-dts: cleanups (or whatever)" in the cover letter of the series. > > [0]: https://lore.kernel.org/netdev/83a35aa3-6cb8-2bc4-2ff4-64278bbcd8c8@xxxxxxxxxx/T/ > > Arınç ÜNAL (4): > staging: mt7621-dts: fix formatting > staging: mt7621-dts: fix switch0@0 warnings > staging: mt7621-dts: use trgmii on gmac0 and enable flow control on port@6 > staging: mt7621-dts: fix pinctrl properties for ethernet > > drivers/staging/mt7621-dts/gbpc2.dts | 16 +++++++++++----- > drivers/staging/mt7621-dts/mt7621.dtsi | 32 ++++++++++++++++---------------- > 2 files changed, 27 insertions(+), 21 deletions(-) > > Thanks for doing this! Best regards, Sergio Paracuellos