Hi Arinc,
On Mon, Jan 24, 2022 at 1:45 PM Arınç ÜNAL <arinc.unal@xxxxxxxxxx> wrote:
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
We need a body for the commit also and not only a short description
for the commit.
> ---
> drivers/staging/mt7621-dts/mt7621.dtsi | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi
> index 644a65d1a6a1..d120e5872165 100644
> --- a/drivers/staging/mt7621-dts/mt7621.dtsi
> +++ b/drivers/staging/mt7621-dts/mt7621.dtsi
> @@ -44,9 +44,9 @@ mmc_fixed_3v3: fixedregulator@0 {
> regulator-max-microvolt = <3300000>;
> enable-active-high;
> regulator-always-on;
> - };
> + };
>
> - mmc_fixed_1v8_io: fixedregulator@1 {
> + mmc_fixed_1v8_io: fixedregulator@1 {
> compatible = "regulator-fixed";
> regulator-name = "mmc_io";
> regulator-min-microvolt = <1800000>;
> @@ -325,17 +325,18 @@ ethernet: ethernet@1e100000 {
>
> mediatek,ethsys = <&sysc>;
>
> -
> gmac0: mac@0 {
> compatible = "mediatek,eth-mac";
> reg = <0>;
> phy-mode = "rgmii";
> +
> fixed-link {
> speed = <1000>;
> full-duplex;
> pause;
> };
> };
> +
> gmac1: mac@1 {
> compatible = "mediatek,eth-mac";
> reg = <1>;
> @@ -343,6 +344,7 @@ gmac1: mac@1 {
> phy-mode = "rgmii-rxid";
> phy-handle = <&phy_external>;
> };
> +
> mdio-bus {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -373,36 +375,43 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
> reg = <0>;
> +
> port@0 {
> status = "off";
> reg = <0>;
> label = "lan0";
> };
> +
> port@1 {
> status = "off";
> reg = <1>;
> label = "lan1";
> };
> +
> port@2 {
> status = "off";
> reg = <2>;
> label = "lan2";
> };
> +
> port@3 {
> status = "off";
> reg = <3>;
> label = "lan3";
> };
> +
> port@4 {
> status = "off";
> reg = <4>;
> label = "lan4";
> };
> +
> port@6 {
> reg = <6>;
> label = "cpu";
> ethernet = <&gmac0>;
> phy-mode = "trgmii";
> +
> fixed-link {
> speed = <1000>;
> full-duplex;
> --
> 2.25.1
>
>
Other than that, this looks good. So feel free to add my:
Reviewed-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
when submitting a new version of this series.
Best regards,
Sergio Paracuellos
