Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void
From: Abdun Nihaal <abdun.nihaal@xxxxxxxxx>
Date: Fri, 7 Jan 2022 15:25:32 +0530
Cc: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, Larry.Finger@xxxxxxxxxxxx, phil@xxxxxxxxxxxxxxxx, straube.linux@xxxxxxxxx, martin@xxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20220107085852.GQ7674@kadam>
References: <cover.1641490034.git.abdun.nihaal@gmail.com> <9db6b08837bd6354c8e07a4b1c4bca662091f945.1641490034.git.abdun.nihaal@gmail.com> <Ydct2sBt6aB+MChS@kroah.com> <20220107065210.7utcwjenvcspydyk@nlap2> <20220107085852.GQ7674@kadam>

Hello,

On Fri, Jan 07, 2022 at 11:58:52AM +0300, Dan Carpenter wrote:
> You're not allowed to end a void function with a return statement.

Sorry, I didn't know that. I'll fix it.

> Checkpatch will only detect these if you run it again with the -f
> option.

Thanks. I'll make sure to run checkpatch on the modified files also (not
just on the patches).

Regards,
Abdun Nihaal

References:
- [PATCH v2 0/2] staging: r8188eu: remove unneeded ret variables
  - From: Abdun Nihaal
- [PATCH v2 2/2] staging: r8188eu: change functions to return void
  - From: Abdun Nihaal
- Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void
  - From: Greg KH
- Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void
  - From: Abdun Nihaal
- Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void
  - From: Dan Carpenter

Prev by Date: [PATCH RFT v2 7/8] media: hantro: output encoded JPEG content directly to capture buffers
Next by Date: [PATCH 00/19] staging: r8188eu: move firmware loading out of the hal layer
Previous by thread: Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void
Next by thread: [PATCH] staging: r8188eu: Check for null pointer after calling skb_clone
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]