This series starts to clean up firmware related code and moves the firmware loading out of rtl8188e_hal_init.c into the new file core/rtw_fw.c. Tested on x86_64 with Inter-Tech DMG-02. Michael Straube (19): staging: r8188eu: remove Firmware* from struct hal_data_8188e staging: r8188eu: remove rtl8188e_InitializeFirmwareVars() staging: r8188eu: release_firmware is not called if allocation fails staging: r8188eu: rename Exit label in load_firmware() staging: r8188eu: rename rtStatus in load_firmware() staging: r8188eu: convert type of return variable in load_firmware() staging: r8188eu: rename parameter pFirmware of load_firmware() staging: r8188eu: rename fields of struct rt_firmware staging: r8188eu: use kmemdup instead of kzalloc and memcpy staging: r8188eu: rename fw related functions to avoid camel case staging: r8188eu: clean up rtw_reset_8051() staging: r8188eu: convert two functions from s32 to int staging: r8188eu: rename Exit label in rtl8188e_firmware_download() staging: r8188eu: rename rtSatus in rtl8188e_firmware_download() staging: r8188eu: rename FWDL_ChkSum_rpt staging: r8188eu: rename writeFW_retry staging: r8188eu: rename pFwHdr in rtl8188e_firmware_download() staging: r8188eu: rename pFirmwareBuf and FirmwareLen staging: r8188eu: move firmware loading code out of the hal layer drivers/staging/r8188eu/Makefile | 1 + drivers/staging/r8188eu/core/rtw_fw.c | 284 ++++++++++++++++ .../staging/r8188eu/hal/rtl8188e_hal_init.c | 303 +----------------- drivers/staging/r8188eu/hal/usb_halinit.c | 8 +- drivers/staging/r8188eu/include/drv_types.h | 4 +- .../staging/r8188eu/include/rtl8188e_hal.h | 10 - .../staging/r8188eu/include/rtl8188e_spec.h | 2 +- drivers/staging/r8188eu/include/rtw_fw.h | 14 + drivers/staging/r8188eu/os_dep/os_intfs.c | 4 +- 9 files changed, 311 insertions(+), 319 deletions(-) create mode 100644 drivers/staging/r8188eu/core/rtw_fw.c create mode 100644 drivers/staging/r8188eu/include/rtw_fw.h -- 2.34.1