On Fri, Jan 07, 2022 at 12:22:10PM +0530, Abdun Nihaal wrote: > Hello Greg, > > On Thu, Jan 06, 2022 at 06:58:50PM +0100, Greg KH wrote: > > On Thu, Jan 06, 2022 at 11:11:52PM +0530, Abdun Nihaal wrote: > > > Some functions in ioctl_linux.c always returns 0 and their return values > > > are never used. Change return type of such functions to void. > > > > > > While at it, align function arguments with open parenthesis to fix > > > checkpatch checks. > > > > > > Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > Signed-off-by: Abdun Nihaal <abdun.nihaal@xxxxxxxxx> > > > > Are you sure that checkpatch allowed this change? > > Yes, I ran checkpatch on both the patches and found no errors, warnings > or checks. Is there something that needs to be fixed? You're not allowed to end a void function with a return statement. Checkpatch will only detect these if you run it again with the -f option. regards, dan carpenter
