On 10/18/21 16:52, Greg Kroah-Hartman wrote:
On Sun, Oct 17, 2021 at 10:46:11PM +0200, Michael Straube wrote:
On 10/17/21 19:46, Martin Kaiser wrote:
Thus wrote Michael Straube (straube.linux@xxxxxxxxx):
On 10/16/21 19:35, Martin Kaiser wrote:
Remove settings from the Makefile that are set by higher-level Makefiles.
Some of those settings might have been useful when the driver was
maintained out of tree.
Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
---
drivers/staging/r8188eu/Makefile | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile
index fccf7e6d1520..8294fb69ecf9 100644
--- a/drivers/staging/r8188eu/Makefile
+++ b/drivers/staging/r8188eu/Makefile
@@ -1,8 +1,3 @@
-SHELL := /bin/bash
-EXTRA_CFLAGS += $(USER_EXTRA_CFLAGS)
-EXTRA_CFLAGS += -O1
-
-ccflags-y += -D__CHECK_ENDIAN__
OUTSRC_FILES := \
hal/HalHWImg8188E_MAC.o \
@@ -46,15 +41,6 @@ _OS_INTFS_FILES := \
_HAL_INTFS_FILES += $(OUTSRC_FILES)
-SUBARCH := $(shell uname -m | sed -e "s/i.86/i386/; s/ppc.*/powerpc/; s/armv.l/arm/; s/aarch64/arm64/;")
-
-ARCH ?= $(SUBARCH)
-CROSS_COMPILE ?=
-KVER ?= $(if $(KERNELRELEASE),$(KERNELRELEASE),$(shell uname -r))
-KSRC ?= $(if $(KERNEL_SRC),$(KERNEL_SRC),/lib/modules/$(KVER)/build)
-MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless
-INSTALL_PREFIX :=
-
rtk_core := \
core/rtw_ap.o \
core/rtw_br_ext.o \
Hi Martin, this patch introduces a GCC warning on my system.
drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function
'rtw_wx_set_enc_ext':
drivers/staging/r8188eu/os_dep/ioctl_linux.c:1929:9: warning: 'strncpy'
specified bound 16 equals destination size [-Wstringop-truncation]
1929 | strncpy((char *)param->u.crypt.alg, alg_name,
IEEE_CRYPT_ALG_NAME_LEN);
|
Hi Michael,
thanks for reporting this. So far, I can't reproduce the warning, even
if I enable -Wstringop-truncation explicitly. I tried this with gcc
8.3.0 (Debian buster) on x86_64.
Hi Martin,
probably only newer gcc versions produce this warning. On my system
the gcc version is 11.2.1 (openSUSE Tumbleweed).
I have gcc 11.1.0 here and I can not duplicate this warning. And it
looks like the code matches other places in the kernel where this
happens, so I'll just take this for now and see if someone wants to send
me a real fix for it, as it is independent of this Makefile change.
thanks,
greg k-h
I totally forgot that I have an alias for building that sets W=1.
That's why I got this warning...
However, I sent a patch to fix it.
Thanks,
Michael
