On 10/17/21 19:46, Martin Kaiser wrote:
Thus wrote Michael Straube (straube.linux@xxxxxxxxx):
On 10/16/21 19:35, Martin Kaiser wrote:
Remove settings from the Makefile that are set by higher-level Makefiles.
Some of those settings might have been useful when the driver was
maintained out of tree.
Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
---
drivers/staging/r8188eu/Makefile | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile
index fccf7e6d1520..8294fb69ecf9 100644
--- a/drivers/staging/r8188eu/Makefile
+++ b/drivers/staging/r8188eu/Makefile
@@ -1,8 +1,3 @@
-SHELL := /bin/bash
-EXTRA_CFLAGS += $(USER_EXTRA_CFLAGS)
-EXTRA_CFLAGS += -O1
-
-ccflags-y += -D__CHECK_ENDIAN__
OUTSRC_FILES := \
hal/HalHWImg8188E_MAC.o \
@@ -46,15 +41,6 @@ _OS_INTFS_FILES := \
_HAL_INTFS_FILES += $(OUTSRC_FILES)
-SUBARCH := $(shell uname -m | sed -e "s/i.86/i386/; s/ppc.*/powerpc/; s/armv.l/arm/; s/aarch64/arm64/;")
-
-ARCH ?= $(SUBARCH)
-CROSS_COMPILE ?=
-KVER ?= $(if $(KERNELRELEASE),$(KERNELRELEASE),$(shell uname -r))
-KSRC ?= $(if $(KERNEL_SRC),$(KERNEL_SRC),/lib/modules/$(KVER)/build)
-MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless
-INSTALL_PREFIX :=
-
rtk_core := \
core/rtw_ap.o \
core/rtw_br_ext.o \
Hi Martin, this patch introduces a GCC warning on my system.
drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function
'rtw_wx_set_enc_ext':
drivers/staging/r8188eu/os_dep/ioctl_linux.c:1929:9: warning: 'strncpy'
specified bound 16 equals destination size [-Wstringop-truncation]
1929 | strncpy((char *)param->u.crypt.alg, alg_name,
IEEE_CRYPT_ALG_NAME_LEN);
|
Hi Michael,
thanks for reporting this. So far, I can't reproduce the warning, even
if I enable -Wstringop-truncation explicitly. I tried this with gcc
8.3.0 (Debian buster) on x86_64.
Hi Martin,
probably only newer gcc versions produce this warning. On my system
the gcc version is 11.2.1 (openSUSE Tumbleweed).
Could you send me your complete compiler command line for this file
(make V=1)?
See end of this mail.
Maybe it's not ok to delete the EXTRA_CFLAGS. I guessed that the
optimisation level would be set by a higher-level Makefile...
The warning is gone when I add back EXTRA_CFLAGS += -O1
Best regards,
Michael
gcc -Wp,-MMD,drivers/staging/r8188eu/os_dep/.ioctl_linux.o.d
-nostdinc -isystem /usr/lib64/gcc/x86_64-suse-linux/11/include
-I./arch/x86/include -I./arch/x86/include/generated -I./include
-I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi
-I./include/uapi -I./include/generated/uapi -include
./include/linux/compiler-version.h -include ./include/linux/kconfig.h
-include ./include/linux/compiler_types.h -D__KERNEL__
-fmacro-prefix-map=./= -DKBUILD_EXTRA_WARN1 -Wall -Wundef
-Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing
-fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration
-Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu89
-mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -fcf-protection=none
-m64 -falign-jumps=1 -falign-loops=1 -mno-80387 -mno-fp-ret-in-387
-mpreferred-stack-boundary=3 -mskip-rax-setup -mtune=generic
-mno-red-zone -mcmodel=kernel -Wno-sign-compare
-fno-asynchronous-unwind-tables -mindirect-branch=thunk-extern
-mindirect-branch-register -fno-jump-tables
-fno-delete-null-pointer-checks -Wno-frame-address
-Wno-format-truncation -Wno-format-overflow
-Wno-address-of-packed-member -O2 -fno-allow-store-data-races
-Wframe-larger-than=2048 -fstack-protector-strong -Werror
-Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable
-Wno-unused-const-variable -fno-stack-clash-protection -g -gdwarf-4 -pg
-mrecord-mcount -mfentry -DCC_USING_FENTRY -Wdeclaration-after-statement
-Wvla -Wno-pointer-sign -Wno-stringop-truncation -Wno-zero-length-bounds
-Wno-array-bounds -Wno-stringop-overflow -Wno-restrict
-Wno-maybe-uninitialized -fno-strict-overflow -fno-stack-check
-fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types
-Werror=designated-init -Wno-packed-not-aligned -Wextra -Wunused
-Wno-unused-parameter -Wmissing-declarations -Wmissing-format-attribute
-Wmissing-prototypes -Wold-style-definition -Wmissing-include-dirs
-Wunused-but-set-variable -Wunused-const-variable -Wpacked-not-aligned
-Wstringop-truncation -Wno-missing-field-initializers -Wno-sign-compare
-Wno-type-limits -Wno-error -DMODULE -DKBUILD_BASENAME='"ioctl_linux"'
-DKBUILD_MODNAME='"r8188eu"' -D__KBUILD_MODNAME=kmod_r8188eu -c -o
drivers/staging/r8188eu/os_dep/ioctl_linux.o
drivers/staging/r8188eu/os_dep/ioctl_linux.c
drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function
'rtw_wx_set_enc_ext':
drivers/staging/r8188eu/os_dep/ioctl_linux.c:1929:9: warning: 'strncpy'
specified bound 16 equals destination size [-Wstringop-truncation]
1929 | strncpy((char *)param->u.crypt.alg, alg_name,
IEEE_CRYPT_ALG_NAME_LEN);
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
