On Mon, 18 Oct 2021 at 23:13, Michael Straube <straube.linux@xxxxxxxxx> wrote: > > Replace strncpy with strlcpy to fix the following gcc warning. > > drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function 'rtw_wx_set_enc_ext': > drivers/staging/r8188eu/os_dep/ioctl_linux.c:1929:9: warning: 'strncpy' specified bound 16 equals destination size [-Wstringop-truncation] > 1929 | strncpy((char *)param->u.crypt.alg, alg_name, IEEE_CRYPT_ALG_NAME_LEN); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > The destination buffer size is IEEE_CRYPT_ALG_NAME_LEN and the length > of the string to copy is always < IEEE_CRYPT_ALG_NAME_LEN. So strlcpy > will never truncate the string. > > Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx> > --- > drivers/staging/r8188eu/os_dep/ioctl_linux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c > index 51f46696a593..4f0ae821d193 100644 > --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c > +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c > @@ -1926,7 +1926,7 @@ static int rtw_wx_set_enc_ext(struct net_device *dev, > return -1; > } > > - strncpy((char *)param->u.crypt.alg, alg_name, IEEE_CRYPT_ALG_NAME_LEN); > + strlcpy((char *)param->u.crypt.alg, alg_name, IEEE_CRYPT_ALG_NAME_LEN); > > if (pext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY) > param->u.crypt.set_tx = 1; > -- > 2.33.0 > Looks good, thanks. Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx> Regards, Phil
