On Sun, May 16, 2021 at 11:38:10AM +0200, Stefan Wahren wrote: > Hi Fabio, > > Am 16.05.21 um 09:27 schrieb Fabio Aiuto: > > Hi Stefan, > > > > On Sat, May 15, 2021 at 09:10:40PM +0200, Stefan Wahren wrote: > >> Recent commit "staging: vchiq_core: drop vchiq_status from vchiq_init_state" > >> missed to change the return type in the definition. Let's fix this now. > > if this patch fixes something that a previous commit broke, > > it's better adding Fixes: tag > > the mentioned commit is still in next, so a Fixes tag doesn't make sense > to me. Or do i miss something? ok, recently I've been told to add a Fixes: tag to a patch fixing a previous not mainlined commit (staging-next). https://lore.kernel.org/linux-staging/YF3qSsH%2F3vRy7BRy@xxxxxxxxx/ but I understand what you mean, let's see :) > > Stefan > > > > >> Signed-off-by: Stefan Wahren <stefan.wahren@xxxxxxxx> > >> --- > >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > >> index ff85327..9b6c626 100644 > >> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > >> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c > >> @@ -2157,7 +2157,7 @@ vchiq_init_slots(void *mem_base, int mem_size) > >> return slot_zero; > >> } > >> > >> -enum vchiq_status > >> +int > >> vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero) > >> { > >> struct vchiq_shared_state *local; > >> -- > >> 2.7.4 > >> > >> > > thank you, > > > > fabio thank you, fabio
