In the first loop in expire_timeout_chk, we may call rtw_free_stainfo and remove an entry from auth_list. In the second loop, we may call list_del_init on our list. Use list_for_each_safe for both loops. Fixes: 23017c8842d2 ("staging: rtl8188eu: Use list iterators and helpers") Signed-off-by: Martin Kaiser <martin@xxxxxxxxx> --- compile-tested only drivers/staging/rtl8188eu/core/rtw_ap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c index ca9a321c4921..a410b42ecb6e 100644 --- a/drivers/staging/rtl8188eu/core/rtw_ap.c +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c @@ -164,7 +164,7 @@ static u8 chk_sta_is_alive(struct sta_info *psta) void expire_timeout_chk(struct adapter *padapter) { - struct list_head *phead, *plist; + struct list_head *phead, *plist, *temp; u8 updated = 0; struct sta_info *psta = NULL; struct sta_priv *pstapriv = &padapter->stapriv; @@ -176,7 +176,7 @@ void expire_timeout_chk(struct adapter *padapter) phead = &pstapriv->auth_list; /* check auth_queue */ - list_for_each(plist, phead) { + list_for_each_safe(plist, temp, phead) { psta = list_entry(plist, struct sta_info, auth_list); if (psta->expire_to > 0) { -- 2.20.1