Re: [PATCH 2/4] spi: spi-fsl-qspi: Fix casting warnings

[Hardevsinh Palaniya <hardevsinh.palaniya@xxxxxxxxxxxxxxxxx>]

Hi Frank,

>>       if (!q->devtype_data->little_endian)
>> -             mask = (u32)cpu_to_be32(mask);
>> +             mask =(__force u32)cpu_to_be32(mask);
>
>Most this kind warning report the real problem. I don't suggest fix as it

Should I drop patches 2 and 4 as per your suggestion.

>the 'if branch' should be removed.
>
>and simple
>
>return read_poll_timeout(qspi_readl, reg, !(reg & mask), delay_us, timeout_us,
                         q, base);
>
>qspi_readl() already handle endian problem.

 would you prefer I resend them with the changes you've recommended?

Best Regards,
Hardev