On Sun, Sep 29, 2024 at 07:22:37AM +0000, Karan Sanghavi wrote: > Converted the brcm,bcm2835-aux-spi.txt file to > its respective yaml file format. > Subject: You do not add new binding, you convert it. Also, drop final full stop. > Signed-off-by: Karan Sanghavi <karansanghvi98@xxxxxxxxx> > --- > diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml > new file mode 100644 > index 000000000000..4c24cf2fe214 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/spi/brcm,bcm2835-aux-spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom BCM2835 Auxiliary SPI1/2 Controller > + > +maintainers: > + - Karan Sanghavi <karansanghvi98@xxxxxxxxx> This is fine, just to be clear: you have the hardware, datasheet or some sort of interest in this hardware? > + > +description: | Do not need '|' unless you need to preserve formatting. > + The BCM2835 contains two forms of SPI master controller. One is known simply as > + SPI0, and the other as the "Universal SPI Master," part of the auxiliary block. > + This binding applies to the SPI1 and SPI2 auxiliary controllers. > + > +allOf: > + - $ref: spi-controller.yaml# > + > +properties: > + compatible: > + enum: > + - brcm,bcm2835-aux-spi > + description: Broadcom BCM2835 Auxiliary SPI controller for SPI1 and SPI2. Drop description > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Reference to the auxiliary clock driver for the BCM2835. Instead: maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/bcm2835-aux.h> > + spi@7e215080 { > + compatible = "brcm,bcm2835-aux-spi"; > + reg = <0x7e215080 0x40>; > + interrupts = <1 29>; > + clocks = <&aux_clocks BCM2835_AUX_CLOCK_SPI1>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > + - | Only one example is enough, drop the rest because they are the same. Best regards, Krzysztof