Re: [PATCH 1/3] gpio: swnode: Add ability to specify native chip selects for SPI

[Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>]

On Tue, Apr 09, 2024 at 09:12:01AM +0200, Linus Walleij wrote:
> On Mon, Apr 8, 2024 at 3:21 PM Charles Keepax
> <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > On Thu, Apr 04, 2024 at 10:16:35AM +0200, Linus Walleij wrote:
> > > On Tue, Mar 26, 2024 at 3:11 PM Charles Keepax
> > > <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > > > +const struct software_node swnode_gpio_undefined = {
> > > > +       .name = "gpio-internal-undefined",
> > > > +};
> > > > +EXPORT_SYMBOL_GPL(swnode_gpio_undefined);
> > >
> > > This needs a comment in the code telling exactly why this is here.
> > > It is also taking up space and code here on systems that have no use
> > > for it, so I wonder if it is possible to make this optional.
> > >
> >
> > Happy to add the comment, less sure about how to make it
> > optional. I could ifdef it based the SPI config, but whilst that
> > is the current user the mechanism feels like it is more generic
> > than that and could be used in other bindings as well.
> 
> That's a fair point.
> Maybe a new bool Kconfig symbol that the SPI drivers or
> other potential users can select?
> 

OK I will add a Kconfig to enable this feature.

Thanks,
Charles