Re: [PATCH v3 3/3] spi: cs42l43: Add bridged cs35l56 amplifiers

[Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>]

On Mon, Apr 08, 2024 at 11:07:43PM +0300, Andy Shevchenko wrote:
> On Mon, Apr 08, 2024 at 10:50:28PM +0300, Andy Shevchenko wrote:
> > On Mon, Apr 08, 2024 at 07:07:55PM +0300, Andy Shevchenko wrote:
> > > On Mon, Apr 8, 2024 at 6:35 PM Charles Keepax
> > > <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote:
> > > > On Wed, Apr 03, 2024 at 11:47:36PM +0300, Andy Shevchenko wrote:
> > > > > Fri, Mar 29, 2024 at 11:47:30AM +0000, Charles Keepax kirjoitti:
> 
> ...
> 
> > > > > > +#include <dt-bindings/gpio/gpio.h>
> > > > >
> > > > > Hmm... Is it requirement by gpiolib-swnode? (I haven't looked at the use cases,
> > > > > I'm not the author of this idea, hence the Q).
> > > >
> > > > It's required for the GPIO_ACTIVE_LOW used in the swnode stuff.
> > > 
> > > Seems to me like you are mistaken.
> > > https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib-swnode.c#L85
> > 
> > Okay, I stand corrected, under "native" the GPIO_* are assumed.
> > 
> > But what you need is to include gpio/property.h for that, and not directly
> > the DT header.
> 
> Oh, my, we have two _almost_ identical definitions in machine.h and under DT.
> So, I believe we are using ones from machine.h.
> 

Yeah that is my bad I should be using those instead.

Thanks,
Charles