Re: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 25 Jan 2024, Andy Shevchenko wrote:

> On Thu, Jan 25, 2024 at 3:55 PM Lee Jones <lee@xxxxxxxxxx> wrote:
> > On Thu, 25 Jan 2024, Charles Keepax wrote:
> >
> > > Use more forward declarations, move header guards to cover other
> > > includes, and rely less on including headers through other headers.
> > >
> > > Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> >
> > Patches look okay to me, but seeing as Andy suggested the changes, it
> > would be good to get a R-by from him.
> 
> I'm worried now only about missing a commit message in one patch and
> (with less severity) the v2 of this one which appears not to be
> necessary (i.e. v1 is fully okay). If you consider the commit message
> absence is okay, feel free to apply v2, otherwise with that addressed
> v3 can go in my opinion.

Please fix-up and submit a v4 with Andy's R-bs.

> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

-- 
Lee Jones [李琼斯]




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux