Re: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 25 Jan 2024, Charles Keepax wrote:

> Use more forward declarations, move header guards to cover other
> includes, and rely less on including headers through other headers.
> 
> Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Patches look okay to me, but seeing as Andy suggested the changes, it
would be good to get a R-by from him.

> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> ---
> 
> Changes since v2:
>  - Added pm.h and regmap.h back into mfd/cs42l43.h
> 
> Thanks,
> Charles
> 
>  drivers/mfd/cs42l43-i2c.c   |  6 +++++-
>  drivers/mfd/cs42l43-sdw.c   |  6 +++++-
>  drivers/mfd/cs42l43.c       |  8 +++++++-
>  drivers/mfd/cs42l43.h       | 10 ++++++----
>  include/linux/mfd/cs42l43.h | 13 +++++++------
>  5 files changed, 30 insertions(+), 13 deletions(-)

-- 
Lee Jones [李琼斯]




[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux