On Thu, Jan 25, 2024 at 12:25 PM Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote: > > Use more forward declarations, move header guards to cover other > includes, and rely less on including headers through other headers. ... > Changes since v2: > - Added pm.h and regmap.h back into mfd/cs42l43.h Btw, TIL that your v1 was fully correct as there is no use of the type definitions. In case you are going to send v3, you can use v1 of this patch if you want, this version is also okay (as we have some more like this pattern, which probably needs to be amended in the future). -- With Best Regards, Andy Shevchenko