Re: [PATCH 0/2] spi: Correct CS GPIOs polarity when using GPIO descriptors

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Thu, May 6, 2021 at 12:44 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Thu, May 6, 2021 at 12:11 PM Jay Fang <f.fangjian@xxxxxxxxxx> wrote:
> > On 2021/5/6 16:14, Andy Shevchenko wrote:
> > > On Thursday, May 6, 2021, Andy Shevchenko <andy.shevchenko@xxxxxxxxx <mailto:andy.shevchenko@xxxxxxxxx>> wrote:
> > >     On Thursday, May 6, 2021, Jay Fang <f.fangjian@xxxxxxxxxx <mailto:f.fangjian@xxxxxxxxxx>> wrote:
> > >
> > >         This series introduces a generic implementation to solve the conflict
> > >         between the 'cs-gpios' flags and the optional SPI slaves flags. So we
> > >         don't need to add two similar quirks separately for DT and ACPI.
>
> > >     NAK. There is a patch against documentation that clarifies polarity of GPIO for ACPI. I have a fix for that to use generic implementation of  CS GPIOs .
> >
> > Thanks. Has the Fix patch been merged ? Commit Id ?

It's here

https://gitlab.com/andy-shev/next/-/commit/5ccbdbb4787d871722f361d77c5f3cb806811c48

and now I remember that I didn't dare to make it as a fix due to:
 - recent (non-fix) dependencies
 - no existing driver uses it for ACPI (at least nothing has been reported)

> Not yet. I'm planning to send it next week (after v5.13-rc1 is out) as a fix.
> For your convenience the whole story is available in my publick branch:
>
> https://gitlab.com/andy-shev/next/-/tree/topic/spi/reload
>
> and yes, I have tested it on real hardware.
>
> > > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=ec3576eac11d66a388b6cba6a7cfb3b45039a712 <https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=ec3576eac11d66a388b6cba6a7cfb3b45039a712>
> > >
> > >
> > > If your ACPI table uses GPIO CS with polarity low (assumes _DSD() is involved), this is a bug. Fix firmware or do a quirk specific for your platform.

-- 
With Best Regards,
Andy Shevchenko