Re: [PATCH 0/2] spi: Correct CS GPIOs polarity when using GPIO descriptors

[Jay Fang <f.fangjian@xxxxxxxxxx>]

On 2021/5/6 16:14, Andy Shevchenko wrote:
> 
> 
> On Thursday, May 6, 2021, Andy Shevchenko <andy.shevchenko@xxxxxxxxx <mailto:andy.shevchenko@xxxxxxxxx>> wrote:
> 
> 
> 
>     On Thursday, May 6, 2021, Jay Fang <f.fangjian@xxxxxxxxxx <mailto:f.fangjian@xxxxxxxxxx>> wrote:
> 
>         This series introduces a generic implementation to solve the conflict
>         between the 'cs-gpios' flags and the optional SPI slaves flags. So we
>         don't need to add two similar quirks separately for DT and ACPI.
> 
> 
>     NAK. There is a patch against documentation that clarifies polarity of GPIO for ACPI. I have a fix for that to use generic implementation of  CS GPIOs .

Thanks. Has the Fix patch been merged ? Commit Id ?

> 
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=ec3576eac11d66a388b6cba6a7cfb3b45039a712 <https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=bleeding-edge&id=ec3576eac11d66a388b6cba6a7cfb3b45039a712>
> 
> 
> If your ACPI table uses GPIO CS with polarity low (assumes _DSD() is involved), this is a bug. Fix firmware or do a quirk specific for your platform.
> 
>  
> 
>      
> 
>         Jay Fang (2):
>           spi: Correct CS GPIOs polarity when using GPIO descriptors
>           Revert "gpio: of: Handle SPI chipselect legacy bindings"
> 
>          drivers/gpio/gpiolib-of.c | 51 ++---------------------------------------------
>          drivers/spi/spi.c         | 22 ++++++++++++++++++--
>          2 files changed, 22 insertions(+), 51 deletions(-)
> 
>         -- 
>         2.7.4
> 
> 
> 
>     -- 
>     With Best Regards,
>     Andy Shevchenko
> 
> 
> 
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>