On Sat, Jul 25, 2020 at 1:42 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Sat, Jul 25, 2020 at 1:37 AM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > > On Fri, Jul 24, 2020 at 11:16:55PM +0300, Andy Shevchenko wrote: ... > > If it's a bug that spi-topcliff-pch.c disables but never enables > > wakeup, I think this should turn into two patches: > > > > 1) Fix the bug by enabling wakeup in suspend (or whatever the right > > fix is), and > > > > 2) Convert to generic PM, which may involve removing the > > wakeup-related code completely. > > Works for me. The only problem here, is that the 2nd is already in the Mark's tree and he doesn't do rebases. So, it will be the other way around. -- With Best Regards, Andy Shevchenko