On Mon, Nov 19, 2018 at 01:46:40PM +0000, Gil Beniamini wrote: > >+ Please wrap lines at less than 80 columns. > Attached is new report & patch, where previously the comment in spi-dw.c exceeded 80 chars per line. Now fixed. This still doesn't visually resemble the standard patch format - like I say git format-patch will do most of it for you (or at least show you what things look like if you're not using git). > >+ That's going to be a pretty long interrupts disabled period added unconditionally which is a bit rude for other users. > >+ As Trent said the normal thing with hardware with half baked chip select control like this is to put the chip select into GPIO mode (or use a separate GPIO if there's not enough pinmux flexibility). > >+ If we do decide to go down this road we should ensure that those users don't have to pay the cost of the interrupt disabled period and only disable the interrupts when using the native chip select > Initially we wanted to use a specific GPI but we have 4 SPI devices and I was told (by our DSP person that it was a dead end), The disable-period is for the "memcpy of bytes or shorts" to spi-fifo > Which is limited by DesignWare-SPI FIFO size (256 bytes) I'm not sure I follow that, you're talking about the FIFO but that's only related to the chip select in that DesignWare have this poor implementation decision. Please also note the feedback above regarding unconditionally disabling interrupts even if not using the internal chip select.
Attachment:
signature.asc
Description: PGP signature
