On Thu, Nov 15, 2018 at 10:00:45AM +0000, Gil Beniamini wrote:
> Hi Mark,
Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to (this is also important for the changelog
for the patch).
> I tried to create new "diff -up" against your SPI git, but it seems that the sources there belongs to kernel 3.x ?!
Most new code should go against for-next.
> Patch Title:Prevent spi-dw write transaction split
> Setup:Linux 4.9.76-rt and 4.9.78-ltsi, using linux-socfpga (Cyclone-V)
>
> Without this patch SPI works fine for us ONLY in 99.999% of the time but not 100% (unless using this submitted patch)
This isn't the format described in SubmitingPatches and most importantly
it's missing the Signed-off-by line which is needed for legal reasons -
if you're having trouble getting your mail client to send things it's OK
to just send as an attachment.
> +++ linux-socfpga/drivers/spi/spi-dw.c2018-11-15 09:21:37.090654999 +0200
> @@ -182,7 +182,13 @@ static void dw_writer(struct dw_spi *dws
> {
> u32 max = tx_max(dws);
> u16 txw = 0;
> +unsigned long flags;
Probably the most critial formatting issue is that all the tabs look to
have been replaced by spaces which means tools can't work with the patch
at all unfortunately.
Attachment:
signature.asc
Description: PGP signature
