Re: [PATCH, V4, 1/5] Documentation: dt: spi-bcm-qspi: NSP, NS2, BRCMSTB SoC bindings

[Florian Fainelli <f.fainelli@xxxxxxxxx>]

On 06/22/2016 07:51 AM, Mark Brown wrote:
> On Fri, Jun 17, 2016 at 05:03:49PM -0400, Kamal Dasu wrote:
>> Added device tree bindings documentation for SoCs supported by the
>> new spi-bcm-qspi driver.
> 
> To repeat what I said on your previous version:
> 
> | So this is a perfect example of why you should use standard formats for
> | subject lines, if things don't look relevant they're likely to get
> | missed.  In this case it's both the prefix and the fact that the version
> | is added in a weird way.  Frankly I didn't even notice that it wasn't a
> | cover letter.
> 
> Please don't ignore review comments, people are generally making them
> for a reason and are likely to have the same concerns if issues remain
> unaddressed.
> 
>> +- compatible:
>> +    Must be one of :
>> +    "brcm,spi-bcm-qspi"
>> +    "brcm,spi-brmstb" spi-nor and/or "brcm,spi-brmstb-mspi" unmanaged SPI Master
> 
> What do these compatible strings mean, what are the differences between
> them?  The last two sound like configuration of a single IP rather than
> descriptions of hardware.

The Broadcom STB SoCs have two instances of this SPI HW block, one which
is MSPI+BSPI capable and another one which is MSPI only (or that's how
we call them), the difference in the compatible strings tries to denote
and capture that.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html