On Fri, Jun 17, 2016 at 05:03:49PM -0400, Kamal Dasu wrote: > Added device tree bindings documentation for SoCs supported by the > new spi-bcm-qspi driver. To repeat what I said on your previous version: | So this is a perfect example of why you should use standard formats for | subject lines, if things don't look relevant they're likely to get | missed. In this case it's both the prefix and the fact that the version | is added in a weird way. Frankly I didn't even notice that it wasn't a | cover letter. Please don't ignore review comments, people are generally making them for a reason and are likely to have the same concerns if issues remain unaddressed. > +- compatible: > + Must be one of : > + "brcm,spi-bcm-qspi" > + "brcm,spi-brmstb" spi-nor and/or "brcm,spi-brmstb-mspi" unmanaged SPI Master What do these compatible strings mean, what are the differences between them? The last two sound like configuration of a single IP rather than descriptions of hardware.
Attachment:
signature.asc
Description: PGP signature
