Re: [PATCH] spi: expose spi_master and spi_device statistics via sysfs

[Martin Sperl <kernel@xxxxxxxxxxxxxxxx>]

> On 20.06.2015, at 14:10, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> Zero-prefixing the numbers in the filenames would make it a bit less ugly
> and auto-sorted…
a possibility

>> histogram as a histogram might be more helpful so people might be
>> happier with debugfs.
> 
> ... but indeed, quoting Documentation/filesystems/debugfs.txt:
> 
> "Unlike sysfs, which has strict one-value-per-file rules, debugfs has no
> rules at all."
> 
> So storing the whole histogram in a single file sounds like the logical
> thing to me.
The point with debugfs would be that we would need to start a
“structure” in the framework that can get easily extended, which obviously
would need more thought, so that a driver can easily expose additional data.

So something along the lines of:
/sys/kernel/debug/spi/<bus>/*
/sys/kernel/debug/spi/<bus>/<device>/*

And with the right api we could make it easily extendable (much more easily
than with sysfs...)

So what I would do I post a patch to expose those “basics” via sysfs and then
a patch to expose the histogram and potentially more via debugfs.

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in