Re: [PATCH] spi: expose spi_master and spi_device statistics via sysfs

[Martin Sperl <kernel@xxxxxxxxxxxxxxxx>]

> On 04.06.2015, at 18:56, Martin Sperl <kernel@xxxxxxxxxxxxxxxx> wrote:
>> We do get to control the permissions on sysfs files, though it's a bit
>> more unusual to make things root only (and there is the histogram).
> 
> I left histogram as a single file because I remember having seen a file in
> /sys with similar semantics using multiple values (but I can not
> remember which one).

Now that I am back here some examples from /sys which contain multiple values:
/sys/devices/platform/soc/20980000.usb/pools:
poolinfo - 0.1
buffer-2048         0    0 2048  0
buffer-512          0    0  512  0
buffer-128          1   32  128  1
buffer-32           0    0   32  0

/sys/devices/platform/soc/20980000.usb/usb1/1-1/1-1.3/1-1.3:1.0/host0/target0:0:0/0:0:0:0/block/sda/sda1/stat:
/sys/devices/platform/soc/20300000.sdhci/mmc_host/mmc0/mmc0:e624/block/mmcblk0/mmcblk0p1/stat:
     425       56     3842      670        7        9      128     2080        0     1530     2750

/sys/kernel/vmcoreinfo:
85d84c 1024

/sys/devices/platform/soc/20300000.sdhci/mmc_host/mmc0/mmc0:e624/block/mmcblk0/inflight:
/sys/devices/platform/soc/20980000.usb/usb1/1-1/1-1.3/1-1.3:1.0/host0/target0:0:0/0:0:0:0/block/sda/sda1/inflight:
       0        0

So it is rare, but not totally uncommon - especially those block statistics.

I can still remove the histogram or move it to separate files per bin
(similar to /sys/kernel/slab/:t-*)

What would you prefer so that I can fix the patch?--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html