Re: [PATCH] spi: expose spi_master and spi_device statistics via sysfs

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

On Fri, Jun 19, 2015 at 12:10 PM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Fri, Jun 19, 2015 at 12:02:22PM +0200, Martin Sperl wrote:
>
>> I got a patch in the meantime exposing the following files in
>> /sys/devices/platform/soc/20204000.spi/spi_master/spi32766/statistics/:
>> bytes
>> bytes_rx
>> bytes_tx
>> bytes_transfer_histo_0-1
>> bytes_transfer_histo_1024-2047
>
>> If so then I would post a “basic” patch for the other statistics
>> and have debugfs for the histogram as a separate patch.
>
> Either approach works for me, though I suppose we might want to bikeshed
> the naming of the histogram files above (but I can't think of better
> ideas immediately) and I guess from a user point of view getting the

Zero-prefixing the numbers in the filenames would make it a bit less ugly
and auto-sorted...

> histogram as a histogram might be more helpful so people might be
> happier with debugfs.

... but indeed, quoting Documentation/filesystems/debugfs.txt:

"Unlike sysfs, which has strict one-value-per-file rules, debugfs has no
 rules at all."

So storing the whole histogram in a single file sounds like the logical
thing to me.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in