Re: [PATCH v1 1/1] spi: clarify what driver can do with message->status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 24, 2015 at 03:33:27PM +0200, Andy Shevchenko wrote:
> On Tue, 2015-02-24 at 22:24 +0900, Mark Brown wrote:

> > > +	/* The actual driver may set this field to indicate an error, e.g. -EIO
> > > +	 * for failed transfer. */
> > >  	int			status;

> > Let's take a step back here: what documentation are you looking at which
> > says anything else about status?

> The description of this field above, namely " * @status: zero for
> success, else negative errno".

...which suggests that anything detecting an error should report it via
status, no?

> > I'd also expect this to go with the other kerneldoc for the field.

> Any place that suits better.

Well, see above...

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux