Re: [PATCH v1 1/1] spi: clarify what driver can do with message->status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 24, 2015 at 12:04:09PM +0200, Andy Shevchenko wrote:
> Currently it's unclear from the documentation if an actual driver may or may
> not override the message->status field. It seems there is no other way to
> indicate an error when transfer is failed, e.g. when gets overrun or underrun
> interrupt. The patch states this clearly in the comments near to field
> definition.

> +
> +	/* The actual driver may set this field to indicate an error, e.g. -EIO
> +	 * for failed transfer. */
>  	int			status;

Let's take a step back here: what documentation are you looking at which
says anything else about status?

I'd also expect this to go with the other kerneldoc for the field.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux