On Mon, Mar 10, 2014 at 08:48:40AM -0700, Steven King wrote: > On Saturday 08 March 2014 10:11:10 pm Axel Lin wrote: > > If pdata->cs_control is NULL, we will hit NULL pointer dereference in > > mcfqspi_cs_select() and mcfqspi_cs_deselect(). Thus add NULL test for > > pdata->cs_control in probe(). > NAK. > I suggest you read the code again. There is no NULL pointer dereference and > further, by returning an error if cs_control is NULL, you've now broken the > design which was that cs_control is optional. So, you've sent this after I'd applied the patch (having ignored prior patches as well, the last activity was in 2012), that's a bit unfortunate. I've reverted the patch but please if you're reviewing changes to the driver can you indicate if things are OK when you do so - if patches aren't getting any review from people working on the driver the tendency is to assume that the driver has been abandoned.
Attachment:
signature.asc
Description: Digital signature
