Re: [PATCH] spi: coldfire-qspi: Prevent NULL pointer dereference

[Steven King <sfking@xxxxxxxxx>]

On Saturday 08 March 2014 10:11:10 pm Axel Lin wrote:
> If pdata->cs_control is NULL, we will hit NULL pointer dereference in
> mcfqspi_cs_select() and mcfqspi_cs_deselect(). Thus add NULL test for
> pdata->cs_control in probe().
>

NAK.

 I suggest you read the code again.  There is no NULL pointer dereference and 
further, by returning an error if cs_control is NULL, you've now broken the 
design which was that cs_control is optional.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html