Re: [PATCH] spi: coldfire-qspi: Prevent NULL pointer dereference

[Steven King <sfking@xxxxxxxxx>]

On Saturday 08 March 2014 10:11:10 pm Axel Lin wrote:
> If pdata->cs_control is NULL, we will hit NULL pointer dereference in
> mcfqspi_cs_select() and mcfqspi_cs_deselect(). Thus add NULL test for
> pdata->cs_control in probe().


D'oh!  My bad.  Actually you're right there would be a NULL pointer 
dereference in cs_select and cs_deselect  (I was looking at the cs_setup and 
cs_teardown in the patch) and so cs_control must not be NULL.  Thats want I 
get for replying before I've had my coffee and when I haven't looked at the 
code in awhile.  So yeah, the patch is GTG.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html