On Tue, Jun 19, 2018 at 08:02:51PM +0100, Ramsay Jones wrote: > > > On 19/06/18 05:50, Luc Van Oostenryck wrote: > > On Mon, Jun 11, 2018 at 03:51:06AM +0200, Luc Van Oostenryck wrote: > >> This series contains some cleanups of the list walking macros. > >> The main changes are: > >> * use structurally equivalent struct for all pointer lists > >> to avoid needless casting to and fro struct ptrlist > >> * simplify PREPARE/NEXT/RESET logic by using common PTR_NEXT() > > > > Ramsay, > > > > Since you reviewed this series, may I add your Reviewed-by before > > pushing it? > > Hmm, I don't think so. :( > > I hope that my comments are useful, but (in the end) I only read > the patches in my email client. As a minimum, I would normally > apply the patches, check the result of application, and actually > do some testing. So, in this case, because I was too busy to go > and fetch the branches from your 'sparse-dev' repo, I don't think > my 'review' was of sufficient quality to warrant a 'Reviewed-by'. > > I try to be helpful I understand and I'm not surprised by your answer but I want to say: * your feedback is very valuable to me and much appreciated * reading the patches and giving some feedback (and finding the patches as appropriate/valauble changes is, in my opinion, what code review is. It takes time, requires competences and increases the quality of the patches, as such it merits to be duly credited (Acked-by is something else which, in my eyes, should gives some quarantees about the quality, appropriateness, ... of the patches). > I try to be helpful, but I am very busy at the moment (I am still > trying to finish my own sparse patch series! Hopefully, I can get > back to that soon). :-D I understand, no problems, there is no hurry. Thank you again for the code reading and the feedback. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
