On Wed, Nov 08, 2017 at 06:42:36AM -0500, Jeff Layton wrote:
> On Sun, 2017-11-05 at 17:25 +0100, Luc Van Oostenryck wrote:
> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
> > ---
> > Makefile | 12 ++----------
> > 1 file changed, 2 insertions(+), 10 deletions(-)
> >
> > diff --git a/Makefile b/Makefile
> > index afc1efe98..f0f7a5b69 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -233,16 +233,8 @@ check: all
> > $(Q)cd validation && ./test-suite
> >
> >
> > -clean: clean-check
> > - @rm -f *.[oa] .*.d $(PROGRAMS) version.h
> > -clean-check:
> > +clean: FORCE
> > @echo ' CLEAN'
> > - @find validation/ \( -name "*.c.output.expected" \
> > - -o -name "*.c.output.got" \
> > - -o -name "*.c.output.diff" \
> > - -o -name "*.c.error.expected" \
> > - -o -name "*.c.error.got" \
> > - -o -name "*.c.error.diff" \
> > - \) -exec rm {} \;
> > + @git clean -q -d -x -e .sparse.mk -e '*.[ch]'
> >
> > .PHONY: FORCE
>
> This seems wrong. It's certainly possible to build sparse out of a
> tarball that was generated from (e.g.) git-archive. In fact that's
> generally how fedora (and I imagine Debian) build packages.
>
> This would break the ability to do "make clean" in that setup.
Yes, it's very wrong.
As you have probably already seen in Uwe's reply, he and Josh have
also reported this and I have since dropped this patch.
I guess that I'm too used to use git ...
It's really good to know that people are looking closely at these patches.
I appreciate this very much.
-- Luc
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
