Re: [PATCH 29/36] build: use git-clean

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On 11/08/2017 12:42 PM, Jeff Layton wrote:
>>  	@echo '     CLEAN'
>> -	@find validation/ \( -name "*.c.output.expected" \
>> -	                 -o -name "*.c.output.got" \
>> -	                 -o -name "*.c.output.diff" \
>> -	                 -o -name "*.c.error.expected" \
>> -	                 -o -name "*.c.error.got" \
>> -	                 -o -name "*.c.error.diff" \
>> -	                 \) -exec rm {} \;
>> +	@git clean -q -d -x -e .sparse.mk -e '*.[ch]'
>>  
>>  .PHONY: FORCE
> 
> This seems wrong. It's certainly possible to build sparse out of a
> tarball that was generated from (e.g.) git-archive. In fact that's
> generally how fedora (and I imagine Debian) build packages.
> 
> This would break the ability to do "make clean" in that setup.

That was already discussed and Luc dropped this change for that reason
in his v2.

Best regards
Uwe

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux